The most challenging part started after writing the code for the issue.

I replied to the issue open on GitHub, and the person in charge of the repository assigned that issue to me.

It was time to send the pull request. The first time I did it, the pull request failed the tests that are in check, as I had forgotten to use pnpm – prettier and pnpm format-check. After I formatted the code the way it should be, it failed the tests again. This time because of the test file.

When I wrote the test file to see if the way I solved the issue works, I did not realise it should be in a specific way. I though that test file would be more for me, to see if what I did works (the screenshot of the test file can be found in the blog post – coding the issue).

After this other error I changed the test file in order for it to support vitest. This is my updated test code now

After updating the test file in the vitest format, I passed all the tests!

Unfortunately, the issue did not get merged. It is still open, as the person who runs the repository wants me to add more to the code.

This is the link where I tried to pull the request and you can see his comments here : https://github.com/tidalcycles/strudel/pull/570

I agree and would love to implement and help contribute to the project even more after this deadline. I just wish he would have been more clear with the issue in the beginning. I saw now that he changed the description of the issue since i have sent the pull request : https://github.com/tidalcycles/strudel/issues/302

I will write more about how I found the whole process and what I have learnt from it in the next blog post.

I have definitely learnt a lot from sending the pull request, even though it did not get merged. First thing would be to read all the instructions more clearly, as I could have avoided my pull requests failing the tests if I had done what I was supposed to do. Also, if I had done more research about how to send the request, I would have seen that the test code should be in vitest format. Will definitely pay more attention to every readme file in a repository from now on.